Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic authorization roles and enforce them. #472

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Add basic authorization roles and enforce them. #472

merged 4 commits into from
Jan 17, 2025

Conversation

uittenbroekrobbert
Copy link
Contributor

Description

Adds basic authorization rules based on the organizations you have acces to and the algorithms linked to those organizations. Also enforces these basic rules. It makes sure you only have (full) access to organizations and algorithms of your organizations.

Resolves #457

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner January 16, 2025 10:03
@uittenbroekrobbert uittenbroekrobbert linked an issue Jan 16, 2025 that may be closed by this pull request
Organization specific views pilotready #457
Closed
@uittenbroekrobbert uittenbroekrobbert force-pushed the 457-organization-specific-views-pilotready branch 3 times, most recently from ab64121 to 1f2d208 Compare January 16, 2025 14:59
@anneschuth
Copy link
Member

anneschuth commented Jan 16, 2025 •
edited
Loading

I've not reviewed the details, but looks great! Had a small comment on simplifying the interface. I think it helps to make that very easy to read (and the proposed change is a tiny refactor)

@uittenbroekrobbert uittenbroekrobbert force-pushed the 457-organization-specific-views-pilotready branch from 1f2d208 to 7072012 Compare January 16, 2025 15:56
anneschuth
anneschuth reviewed Jan 16, 2025
View reviewed changes
amt/api/decorators.py Outdated Show resolved Hide resolved
@uittenbroekrobbert uittenbroekrobbert force-pushed the 457-organization-specific-views-pilotready branch 2 times, most recently from ebbfdd5 to 439faed Compare January 17, 2025 11:13
@uittenbroekrobbert uittenbroekrobbert force-pushed the 457-organization-specific-views-pilotready branch from 439faed to f09e230 Compare January 17, 2025 12:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ChristopherSpelt
ChristopherSpelt approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uittenbroekrobbert uittenbroekrobbert merged commit 36b04ba into main Jan 17, 2025
15 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 457-organization-specific-views-pilotready branch January 17, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneschuth anneschuth anneschuth left review comments

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organization specific views pilotready
3 participants
@uittenbroekrobbert @anneschuth @ChristopherSpelt