Add more editable fields, fix for the task registry api client caching #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # amt/api/routes/algorithm.py # amt/locale/base.pot # amt/locale/en_US/LC_MESSAGES/messages.mo # amt/locale/en_US/LC_MESSAGES/messages.po # amt/locale/nl_NL/LC_MESSAGES/messages.mo # amt/locale/nl_NL/LC_MESSAGES/messages.po # tests/api/routes/test_algorithm.py # tests/e2e/test_create_algorithm.py # tests/fixtures/vcr_cassettes/test_fetch_task_with_invalid_urn.yml # tests/fixtures/vcr_cassettes/test_fetch_task_with_urn.yml # tests/fixtures/vcr_cassettes/test_fetch_task_with_urns.yml # tests/fixtures/vcr_cassettes/test_fetch_task_with_valid_and_invalid_urn.yml # tests/fixtures/vcr_cassettes/test_fetch_tasks_all.yml # tests/fixtures/vcr_cassettes/test_get_assessment_card.yml # tests/fixtures/vcr_cassettes/test_get_model_card.yml # tests/fixtures/vcr_cassettes/test_get_system_card_data_page.yml # tests/fixtures/vcr_cassettes/test_get_system_card_instruments.yml # tests/fixtures/vcr_cassettes/test_get_system_card_requirements.yml # Conflicts: # amt/clients/clients.py # tests/repositories/test_task_registry.py
rubenrouwhof
previously approved these changes
Jan 15, 2025
uittenbroekrobbert
force-pushed
the
379-edit-objects-in-algorithm-details-section
branch
4 times, most recently
from
d000863 to
c590e2c
Compare
uittenbroekrobbert
force-pushed
the
379-edit-objects-in-algorithm-details-section
branch
from
c590e2c to
3ced93c
Compare
|
ChristopherSpelt
approved these changes
Jan 15, 2025
uittenbroekrobbert
deleted the
379-edit-objects-in-algorithm-details-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the alru cache did not work due to the TaskRegistryClient being a parameter. We now use 1 global TaskRegistryClient.
Checklist
Please check all the boxes that apply to this pull request using "x":