Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: hardcoded id for generated id field #453

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Fix: hardcoded id for generated id field #453

merged 2 commits into from
Jan 7, 2025

Conversation

uittenbroekrobbert
Copy link
Contributor

Description

This fixes a bug in the migration script. When inserting the default authorizations, a hardcoded id was used for a generated id field.

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner January 7, 2025 07:37
@uittenbroekrobbert uittenbroekrobbert marked this pull request as draft January 7, 2025 08:17
berrydenhartog
berrydenhartog previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert force-pushed the fix-authorization-migration branch from 3aec06c to dfd4517 Compare January 7, 2025 08:26
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@uittenbroekrobbert uittenbroekrobbert marked this pull request as ready for review January 7, 2025 08:37
berrydenhartog
berrydenhartog approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert merged commit f5bbd66 into main Jan 7, 2025
15 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the fix-authorization-migration branch January 7, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uittenbroekrobbert @berrydenhartog