Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug instrument names with links #452

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Fix bug instrument names with links #452

merged 3 commits into from
Jan 8, 2025

Conversation

ravimeijerrig
Copy link
Contributor

Description

In this PR, we:

  • Make sure the instrument names appear separate from each other in a list with links

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ravimeijerrig ravimeijerrig linked an issue Jan 6, 2025 that may be closed by this pull request
Bug: Assessments in systemcard viewer without space #444
Closed
@ravimeijerrig ravimeijerrig marked this pull request as ready for review January 6, 2025 09:06
@ravimeijerrig ravimeijerrig requested a review from a team as a code owner January 6, 2025 09:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

anneschuth
anneschuth approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ravimeijerrig ravimeijerrig merged commit cf5de19 into main Jan 8, 2025
15 checks passed
@ravimeijerrig ravimeijerrig deleted the 444-bug-assessments-in-systemcard-viewer-without-space branch January 8, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anneschuth anneschuth anneschuth approved these changes

@uittenbroekrobbert uittenbroekrobbert Awaiting requested review from uittenbroekrobbert

@ChristopherSpelt ChristopherSpelt Awaiting requested review from ChristopherSpelt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Assessments in systemcard viewer without space
2 participants
@ravimeijerrig @anneschuth