Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pydantic related errors due to handling None values #439

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix pydantic related errors due to handling None values #439

merged 1 commit into from
Dec 18, 2024

Conversation

uittenbroekrobbert
Copy link
Contributor

Description

Fixes the Pydantic models that have optional None fields and the handling of those changes in other locations in the codebase.

Resolves #438

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@uittenbroekrobbert uittenbroekrobbert requested a review from a team as a code owner December 18, 2024 11:03
@uittenbroekrobbert uittenbroekrobbert linked an issue Dec 18, 2024 that may be closed by this pull request
Fix Pyright errors when updating Pydantic #438
Closed
berrydenhartog
berrydenhartog requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/services/test_instruments_state.py Show resolved Hide resolved
@uittenbroekrobbert uittenbroekrobbert force-pushed the 438-fix-pyright-errors-when-updating-pydantic branch from 5904f55 to d8914e9 Compare December 18, 2024 13:38
@uittenbroekrobbert uittenbroekrobbert force-pushed the 438-fix-pyright-errors-when-updating-pydantic branch from d8914e9 to c0bfcfd Compare December 18, 2024 13:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
89.2% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

berrydenhartog
berrydenhartog approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uittenbroekrobbert uittenbroekrobbert merged commit 36398f2 into main Dec 18, 2024
14 of 15 checks passed
@uittenbroekrobbert uittenbroekrobbert deleted the 438-fix-pyright-errors-when-updating-pydantic branch December 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Pyright errors when updating Pydantic
2 participants
@uittenbroekrobbert @berrydenhartog