Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message above field #302

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add error message above field #302

merged 1 commit into from
Oct 24, 2024

Conversation

berrydenhartog
Copy link
Member

Description

Add pydantic errors near fields and translate the pydantic errors

Resolves #193

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog linked an issue Oct 21, 2024 that may be closed by this pull request
Update error states for new project page #193
Closed
@berrydenhartog berrydenhartog force-pushed the 193-update-error-states-for-new-project-page branch 9 times, most recently from a7d9269 to f223ae3 Compare October 23, 2024 11:19
@berrydenhartog berrydenhartog marked this pull request as ready for review October 23, 2024 11:20
@berrydenhartog berrydenhartog requested a review from a team as a code owner October 23, 2024 11:20
@berrydenhartog berrydenhartog force-pushed the 193-update-error-states-for-new-project-page branch 3 times, most recently from d8e6c1a to e7e2f9c Compare October 23, 2024 11:33
ChristopherSpelt
ChristopherSpelt previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor detail

amt/locale/nl_NL/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
@berrydenhartog berrydenhartog force-pushed the 193-update-error-states-for-new-project-page branch from e7e2f9c to 6472614 Compare October 24, 2024 20:32
@berrydenhartog berrydenhartog force-pushed the 193-update-error-states-for-new-project-page branch from 6472614 to 4c70e0c Compare October 24, 2024 20:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rubenrouwhof rubenrouwhof requested review from rubenrouwhof and removed request for rubenrouwhof October 24, 2024 21:32
rubenrouwhof
rubenrouwhof approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@rubenrouwhof rubenrouwhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berrydenhartog berrydenhartog merged commit 0a0fa74 into main Oct 24, 2024
14 checks passed
@berrydenhartog berrydenhartog deleted the 193-update-error-states-for-new-project-page branch October 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenrouwhof rubenrouwhof rubenrouwhof approved these changes

@ChristopherSpelt ChristopherSpelt ChristopherSpelt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update error states for new project page
3 participants
@berrydenhartog @rubenrouwhof @ChristopherSpelt