Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement design suggestions #307

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Implement design suggestions #307

merged 4 commits into from
Dec 19, 2024

Conversation

ravimeijerrig
Copy link
Collaborator

@ravimeijerrig ravimeijerrig commented Dec 18, 2024 •
edited
Loading

Description

In this PR we implement the following design improvements:

  • Replace beta-banner
  • Delete unnecessary double questions
  • Make distinction between question and explanation more clear

Notes:

  • I struggled adding the beta-banner in the index.html so eventually moved the beta banner and logo to header.vue

Old:
Screenshot 2024-12-18 at 16 19 14

New:
image

Resolves #

@ravimeijerrig ravimeijerrig marked this pull request as ready for review December 18, 2024 15:22
laurensWe
laurensWe approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravimeijerrig ravimeijerrig merged commit 0130727 into main Dec 19, 2024
4 checks passed
@ravimeijerrig ravimeijerrig deleted the Fix_design branch December 19, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurensWe laurensWe laurensWe approved these changes

@ruthkoole ruthkoole Awaiting requested review from ruthkoole ruthkoole is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravimeijerrig @laurensWe