-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tad reporting standard #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Left some remarks. Some may be debatable or premature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is great, the amount of details is just right and I think it captures everything that we would deem necessary for modelcards (both technical and assessmental) and it is flexibel enough to be extended by different graph measurements for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristopherSpelt thanks for this initial proposal for the TAD reporting standard. With this review I hope to share some additional ideas, so we can make it even better. If you want to discuss some of my comments, please let me know.
8ac1fae
to
e4b8696
Compare
Co-authored-by: Anne Schuth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor remark, looks really good to me now :)
Co-authored-by: Laurens Weijs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristopherSpelt thanks for this new version. I left some comments and suggestions. I also propose to have a (short) meeting to talk about a couple of comments because I think that way we can align on them faster. I will bring it up during the standup tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 3 small ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristopherSpelt thanks for this new version. I think we should merge this version, so we can finish the first itteration. It was great working with you, and the team, on this!
There is one "bug" we should fix before we can complete this PR. The rest of my comments are just suggestions. Feel free to ignore them.
Co-authored-by: Robbert Bos <[email protected]>
Co-authored-by: Robbert Bos <[email protected]>
Co-authored-by: Robbert Bos <[email protected]>
Co-authored-by: Robbert Bos <[email protected]>
Co-authored-by: Robbert Bos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
TAD Reporting Standard
This PR contains the first version of the TAD reporting standard.
Reading order suggestions:
Expected shortcomings:
The shortcomings will probably be exposed at the moment we will try to actually write an example output, at which point we can address them.