fixed youtube-dl download status not being shown

MilchRatchet · Oct 3, 2020 · 63f2916 · 63f2916
1 parent 367e998
commit 63f2916
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/SubBox/Models/Downloader.cs b/SubBox/Models/Downloader.cs
@@ -67,18 +67,8 @@ public static void DownloadFiles()
                         }
                     };
 
-                    try
-                    {
-                        client.DownloadFile(new Uri("https://youtube-dl.org/downloads/latest/youtube-dl.exe"), "youtube-dl.exe");
-                    }
-                    catch (Exception m)
-                    {
-                        Logger.Info("Failed downloading youtube-dl");
-
-                        Logger.Info("Please open an issue on Github if this issue persists");
-
-                        Logger.Error(m.Message);
-                    }
+                    //this may crash SubBox if the link does not work anymore, try catch does not work for async methods
+                    client.DownloadFileAsync(new Uri("https://youtube-dl.org/downloads/latest/youtube-dl.exe"), "youtube-dl.exe");
                 }
 
                 //ffmpeg is to be included in releases until a stable download option is found now that zeranoe is no more