Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update private cloud doc and some more details on sshd in prereqs #43

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

StevenBucher98
Copy link
Contributor

Removing the note about no longer supporting public clouds and adding some more details on the prereqs to make it more clear that the sshd server needs to be enabled.

Copy link
Contributor

@StevenBucher98 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 44e4311:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/container-registry/index.yml ⚠️Warning Details
articles/azure-arc/servers/ssh-arc-overview.md 💡Suggestion Details

articles/container-registry/index.yml

  • Line 10, Column 18: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.subservice': 'subservice' is not valid with 'ms.service' value 'azure-container-registry'.

articles/azure-arc/servers/ssh-arc-overview.md

  • Line 59, Column 266: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/azure-arc/servers/ssh-arc-troubleshoot?tabs=azure-cli' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit ec797a2:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/container-registry/index.yml ⚠️Warning Details
articles/azure-arc/servers/ssh-arc-overview.md ✅Succeeded

articles/container-registry/index.yml

  • Line 10, Column 18: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.subservice': 'subservice' is not valid with 'ms.service' value 'azure-container-registry'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@@ -20,11 +20,25 @@ SSH access to Arc-enabled servers provides the following key benefits:

## Prerequisites

- User Permissions: Owner or Contributor role assigned for the target Arc-enabled server.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessarily required. You need Owner or contributor to set the default endpoint and service configuration, but once those are set up you don't need that much permission. If I'm not mistaken you need "Virtual Machine Local User Login"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that is what was documented before, so I guess it means that's the requirement for setting up the feature. But it's a little confusing.

@v-dirichards
Copy link
Contributor

@vthiebaut10 Would you add a comment to indicate what action to take on this PR? Thanks!

@v-dirichards v-dirichards added the aq-pr-triaged C+L Pull Request Review Team label label Jan 28, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Feb 12, 2025
@vthiebaut10
Copy link

This PR can be merged

@johnmarco
Copy link
Contributor

#sign-off

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Feb 12, 2025
Copy link
Contributor

Learn Build status updates of commit d58736f:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-arc/servers/ssh-arc-overview.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ShannonLeavitt ShannonLeavitt merged commit ad32bb5 into MicrosoftDocs:main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants