[BrokenLinksH2] Fixed broken links #646
Conversation
|
Docs Build status updates of commit 836c7d6: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit e89defb: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 6e4625b: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Global effort to fix broken links @nmetulev The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes and does not change other content. I’d very much appreciate your timely review and feedback on the link changes I’ve suggested. Thanks! |
docs/controls/ScrollHeader.md
Outdated
| @@ -67,4 +67,4 @@ The [ScrollHeader](/dotnet/api/microsoft.toolkit.uwp.ui.controls.scrollheader) c | |||
|
|
|||
| ## API | |||
|
|
|||
| * [ScrollHeader source code](https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader) | |||
| * ScrollHeader source code `(https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader)` | |||
There was a problem hiding this comment.
Invalid link, possible markdown typos
There was a problem hiding this comment.
| * ScrollHeader source code `(https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader)` | |
| * [ScrollHeader source code](https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/6.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader) |
There was a problem hiding this comment.
@michael-hawker Same question about the version. :-)
docs/controls/TabView.md
Outdated
| @@ -133,11 +133,11 @@ The TabView supports data binding as well. The following example shows binding | |||
|
|
|||
| ## Sample Project | |||
|
|
|||
| [TabView Sample Page Source](https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/7.1.0/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TabView). You can [see this in action](uwpct://Controls?sample=TabView) in the [Windows Community Toolkit Sample App](https://aka.ms/windowstoolkitapp). | |||
| TabView Sample Page Source `(https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/7.1.0/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TabView)`. You can [see this in action](uwpct://Controls?sample=TabView) in the [Windows Community Toolkit Sample App](https://aka.ms/windowstoolkitapp). | |||
There was a problem hiding this comment.
Invalid link, possible markdown typos
There was a problem hiding this comment.
| TabView Sample Page Source `(https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/7.1.0/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TabView)`. You can [see this in action](uwpct://Controls?sample=TabView) in the [Windows Community Toolkit Sample App](https://aka.ms/windowstoolkitapp). | |
| [TabView Sample Page Source](https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/rel/6.1.1/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TabView). You can [see this in action](uwpct://Controls?sample=TabView) in the [Windows Community Toolkit Sample App](https://aka.ms/windowstoolkitapp). |
There was a problem hiding this comment.
Same version question for links on this page--update or remove?
| @@ -48,7 +48,7 @@ The [StaggeredPanel](/dotnet/api/microsoft.toolkit.uwp.ui.controls.staggeredpane | |||
|
|
|||
| ## Default Template | |||
|
|
|||
| [StaggeredPanel XAML File](https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/StaggeredPanel/StaggeredPanel.xaml) is the XAML template used in the toolkit for the default styling. | |||
| StaggeredPanel XAML File `(https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/StaggeredPanel/StaggeredPanel.xaml)` is the XAML template used in the toolkit for the default styling. | |||
There was a problem hiding this comment.
Invalid link, possible markdown typos
There was a problem hiding this comment.
It looks like the link should be https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls.Primitives/StaggeredPanel/StaggeredPanel.xaml, but the file doesn't exist & doesn't seem to be in previous versions either.
However, I did find a sample xaml file: https://github.com/CommunityToolkit/WindowsCommunityToolkit/blob/rel/7.1.0/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/StaggeredPanel/StaggeredPanelPage.xaml
@michael-hawker Should we delete this section, or link to the sample file?
|
@Arlodotexe this is what I was calling out on the other PR #645 (which still has some as well). It's because @kturetz didn't find the new location in our repo, so he commented it out instead. This is a combination of a few things:
The main issue with trying to do this across the current docs is that we're basically planning on redoing our docs anyway for our next 8.0 release before year-end, so most of this is going to be temp effort as everything will change again. |
Please let us know if you require any additional edits that will expedite review and merge of this PR. Thank you. |
docs/controls/ScrollHeader.md
Outdated
| @@ -56,7 +56,7 @@ The [ScrollHeader](/dotnet/api/microsoft.toolkit.uwp.ui.controls.scrollheader) c | |||
|
|
|||
| ## Default Template | |||
|
|
|||
| [ScrollHeader XAML File](https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader/ScrollHeader.xaml) is the XAML template used in the toolkit for the default styling. | |||
| ScrollHeader XAML File `(https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader/ScrollHeader.xaml)` is the XAML template used in the toolkit for the default styling. | |||
There was a problem hiding this comment.
| ScrollHeader XAML File `(https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/rel/7.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader/ScrollHeader.xaml)` is the XAML template used in the toolkit for the default styling. | |
| [ScrollHeader XAML File](https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/rel/6.1.0/Microsoft.Toolkit.Uwp.UI.Controls/ScrollHeader/ScrollHeader.xaml) is the XAML template used in the toolkit for the default styling. |
There was a problem hiding this comment.
@michael-hawker Is it more appropriate to remove this section, or link to the sample, than to reference an older version?
|
Docs Build status updates of commit e68fd1a: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 8df8eb2: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
@michael-hawker I think this is ready to merge. If not, we can close this PR and I'll have someone else from my team finish the work. Thanks! |
|
Commenting out these broken links (while reviewing the replacements I've noted for others) and waiting for the repo team's new release to resolve them is an option. If you'd like to take that route, let's complete and merge these PRs.
In the meantime, let's look at an example that might help me enact additional fixes. Is there a working version of this link and if so, how would I determine it using the information Michael provided here?
[PersonView source code](https://github.com/windows-toolkit/Graph-Controls/tree/dev/7.1.0/CommunityToolkit.Graph.Uwp/Controls/PersonView)
From: Michael Hawker MSFT (XAML Llama) ***@***.***>
Sent: Thursday, June 9, 2022 5:05 PM
To: MicrosoftDocs/WindowsCommunityToolkitDocs ***@***.***>
Cc: Ken Turetzky (AQUENT LLC) ***@***.***>; Mention ***@***.***>
Subject: Re: [MicrosoftDocs/WindowsCommunityToolkitDocs] [BrokenLinksH2] Fixed broken links (PR #646)
@Arlodotexe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FArlodotexe&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IXv20lA0soVI2ijRMqp57tNhnmCo4NK0VQMheRc4308%3D&reserved=0> this is what I was calling out on the other PR #645<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FWindowsCommunityToolkitDocs%2Fpull%2F645&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oawrVdh7QEzf0v76upn3Vrvne3rSudHAL7RLwAb8xms%3D&reserved=0> (which still has some as well).
It's because @kturetz<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkturetz&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nBOZwnW5WKu%2FObl2vcKQDTIphBrfMuFmU0bnI%2F2HtyY%3D&reserved=0> didn't find the new location in our repo, so he commented it out instead.
This is a combination of a few things:
* our repo org changed from windows-toolkit to CommunityToolkit (easy replacement)
* uncaught changes from large 7.0 package refactor (a lot of these mean that anything with .Controls is probably now .Controls.<Subpackage>.
* Animations refactor where somethings were removed/deprecated
* Clean-ups to locations of some samples for animations/shadows
The main issue with trying to do this across the current docs is that we're basically planning on redoing our docs anyway for our next 8.0 release before year-end, so most of this is going to be temp effort as everything will change again.
-
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FWindowsCommunityToolkitDocs%2Fpull%2F646%23issuecomment-1151623248&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Jn0aunxeULwZBeKThADNVAOc72Rj8fDykx9nYTsPJlI%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAY4PHJET37GFNDTMLO5MQZLVOJL7DANCNFSM5YIFDBIQ&data=05%7C01%7Cv-kturetzky%40microsoft.com%7Ce8cbcc9c859248a0f6ed08da4a5bb114%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637904054924619113%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MGxGTIyBvJC0lbfEO0s%2FU5T9AJb78xl5UEGgrxasszQ%3D&reserved=0>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No description provided.