Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified code for batch inference #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iamrishab
Copy link

@MhLiao
Copy link
Owner

MhLiao commented Nov 21, 2019

Thanks for your contribution! I am checking the pull request. It seems that you modified the indentations so it is hard to see the actual changes of the code since most of the lines are labeled as differences.

@iamrishab
Copy link
Author

Thanks for your feedback. I will fix the indentation and create a new pull request.

@MhLiao
Copy link
Owner

MhLiao commented Nov 23, 2019

@iamrishab It seems that the char maps are wrongly localized with the current PR.

@iamrishab
Copy link
Author

@MhLiao
Hi! I have already tested the code and it's able localize the char maps correctly

@iamrishab
Copy link
Author

@MhLiao will you be able to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants