Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Table /> refactor #212

Merged
merged 6 commits into from
Dec 6, 2023
Merged

<Table /> refactor #212

merged 6 commits into from
Dec 6, 2023

Conversation

travor20814
Copy link
Collaborator

@travor20814 travor20814 commented Dec 5, 2023

BREAKING CHANGES

/* Success */
const column = {
  render: (source) => source.foo,
  renderTitle: () => 'Custom Title',
};

/* Success */
const column = {
  dataIndex: 'foo',
  title: 'title',
};

/* Failed */
const column = {
  dataIndex: 'foo',
  render: (source) => source.foo, // TypeError: render should be `undefined`
  title: 'title',
};

@travor20814 travor20814 marked this pull request as draft December 5, 2023 07:33
Copy link

cloudflare-workers-and-pages bot commented Dec 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0a927e
Status: ✅  Deploy successful!
Preview URL: https://2640c7c4.mezzanine-ui.pages.dev
Branch Preview URL: https://feat-table-refactor.mezzanine-ui.pages.dev

View logs

@travor20814 travor20814 marked this pull request as ready for review December 6, 2023 03:31
@travor20814 travor20814 merged commit 80b024c into main Dec 6, 2023
2 checks passed
@travor20814 travor20814 deleted the feat/table-refactor branch November 22, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance declaration of TableColumn Props refactor Table propTypes
1 participant