Skip to content

Commit

Permalink
Merge pull request #306 from Meteor-Community-Packages/migrate/3.0
Browse files Browse the repository at this point in the history
Migrate for Meteor 3.0
StorytellerCZ authored Dec 6, 2024
2 parents e09a88d + 8b787ab commit e02c9c0
Showing 52 changed files with 2,756 additions and 2,135 deletions.
1 change: 1 addition & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -7,6 +7,7 @@
],
"parserOptions": {
"sourceType": "module",
"ecmaVersion": 2022,
"ecmaFeatures": {
"modules": true
}
6 changes: 3 additions & 3 deletions .github/workflows/codelint.yml
Original file line number Diff line number Diff line change
@@ -11,12 +11,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Install Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: '14.x'
node-version: '20.x'

- name: Install Dependencies
run: |
6 changes: 2 additions & 4 deletions .github/workflows/testsuite.yml
Original file line number Diff line number Diff line change
@@ -12,10 +12,7 @@ jobs:
strategy:
matrix:
meteorRelease:
- '--release 2.3'
- '--release 2.8.1'
- '--release 2.14'
# Latest version
- '--release 3.0.4'
steps:
- name: Checkout code
uses: actions/checkout@v4
@@ -29,6 +26,7 @@ jobs:
run: |
curl https://install.meteor.com | /bin/sh
npm i -g @zodern/mtest
- name: Run Tests
run: |
mtest --package ./ --once ${{ matrix.meteorRelease }}
10 changes: 10 additions & 0 deletions History.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## v2.0.0

* BREAKING: find hooks have been removed (due to Meteor 3 compatibility)
* Async hooks are now supported
* Meteor 3.0 is now the minimum required Meteor version

## v1.4.0
* Test suite minimum Meteor version is 2.12 to support new counts and to be fully compatible with Meteor 3
* Meteor `3.0-beta.0` is now a supported version, but not functionality wise (need to upgrade `count` functions in tests)

## v1.3.2
* Updated `zodern:types` to v1.0.13 [@storytellercz](https://github.com/sponsors/StorytellerCZ)
* Updated Meteor 3 supported version to `3.0-rc.10` for migration support, but will release full 3.0 supported version soon. [@storytellercz](https://github.com/sponsors/StorytellerCZ)
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -195,7 +195,9 @@ test.before.find(function (userId, selector, options) {
});
```

__Important:__ This hook does not get called for `after.update` hooks (see https://github.com/Meteor-Community-Packages/meteor-collection-hooks/pull/297).
__Important:__
- The function used as `before.find` hook cannot be async
- This hook does not get called for `after.update` hooks (see https://github.com/Meteor-Community-Packages/meteor-collection-hooks/pull/297).

--------------------------------------------------------------------------------

2 changes: 1 addition & 1 deletion client.js
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ import { Meteor } from 'meteor/meteor'
import { Tracker } from 'meteor/tracker'
import { CollectionHooks } from './collection-hooks.js'

import './advices'
import './wrappers.js'

CollectionHooks.getUserId = function getUserId () {
let userId
Loading

0 comments on commit e02c9c0

Please sign in to comment.