Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add warning message to react-metamask-button example dapp #924

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

christopherferreira9
Copy link
Collaborator

@christopherferreira9 christopherferreira9 commented Jun 27, 2024

Explanation

Adds a warning to the react-metamask-button example dapp since a recent bug found in it is causing the mobile wallet to crash.

This message should be removed once the issue is fixed.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner June 27, 2024 15:03
@christopherferreira9 christopherferreira9 self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (90f2b7e) to head (282db65).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   86.53%   86.62%   +0.09%     
==========================================
  Files         177      177              
  Lines        3868     3859       -9     
  Branches      952      947       -5     
==========================================
- Hits         3347     3343       -4     
+ Misses        521      516       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@christopherferreira9 christopherferreira9 merged commit 23127c4 into main Jul 1, 2024
37 checks passed
@christopherferreira9 christopherferreira9 deleted the chore/add-warning-react-metamask-button branch July 1, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants