Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user rejection bug #1202

Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix: user rejection bug #1202

merged 2 commits into from
Jan 20, 2025

Conversation

chakra-guy
Copy link
Collaborator

@chakra-guy chakra-guy commented Jan 20, 2025

Explanation

This PR fixes the issue for: wevm/wagmi#4504

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@chakra-guy chakra-guy requested a review from a team as a code owner January 20, 2025 10:06
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.05%. Comparing base (2551701) to head (8b5fc81).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/sdk/src/ui/InstallModal/Modal-web.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   74.06%   74.05%   -0.02%     
==========================================
  Files         182      182              
  Lines        4350     4351       +1     
  Branches     1066     1066              
==========================================
  Hits         3222     3222              
- Misses       1128     1129       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chakra-guy chakra-guy merged commit 9ec21db into main Jan 20, 2025
34 of 36 checks passed
@chakra-guy chakra-guy deleted the fix-wagmi-user-rejection-bug branch January 20, 2025 11:00
@christopherferreira9 christopherferreira9 mentioned this pull request Jan 20, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants