Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add analytics to install modal #1189
base: main
Are you sure you want to change the base?
chore: add analytics to install modal #1189
Changes from 4 commits
f8c929a
dfe6429
f5d8e6f
85db7b3
dd21986
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit: it's probably best to have this be invoked inside
componentDidLoad()
lifecycle method. This may be more correct to do, but you'll need to add the lifecycle method to these componentsCheck warning on line 45 in packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts
Codecov / codecov/patch
packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts#L44-L45
Check warning on line 48 in packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts
Codecov / codecov/patch
packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts#L48
Check warning on line 50 in packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts
Codecov / codecov/patch
packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts#L50
Check warning on line 52 in packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts
Codecov / codecov/patch
packages/sdk/src/services/RemoteConnection/ModalManager/showInstallModal.ts#L52
Check warning on line 90 in packages/sdk/src/ui/InstallModal/Modal-web.ts
Codecov / codecov/patch
packages/sdk/src/ui/InstallModal/Modal-web.ts#L89-L90