-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add analytics to install modal #1189
base: main
Are you sure you want to change the base?
Conversation
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
==========================================
- Coverage 74.40% 74.28% -0.13%
==========================================
Files 181 181
Lines 4306 4313 +7
Branches 1057 1061 +4
==========================================
Hits 3204 3204
- Misses 1102 1109 +7 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit
@@ -47,6 +51,14 @@ export class InstallModal { | |||
this.setTab(this.preferDesktop ? 1 : 2); | |||
|
|||
this.i18nInstance = new SimpleI18n(); | |||
|
|||
this.trackAnalytics.emit({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit: it's probably best to have this be invoked inside componentDidLoad()
lifecycle method. This may be more correct to do, but you'll need to add the lifecycle method to these components
Explanation
We added analytics for modal interactions—viewed, button clicked, and toggle changed—but omitted QR scan detection as it's currently not feasible. We also fixed a minor bug. These changes ensure we capture essential user actions within the install modal.
Here are some log from the socket server:
sdk_modal_viewed
sdk_modal_button_clicked
sdk_modal_toggle_changed
References
No direct issue references.
Checklist