fix: correct event handler binding in modal components (#1191)

fix: invalid scope on modal
MetaMask · Jan 10, 2025 · fe95d03 · fe95d03
1 parent f42502c
commit fe95d03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/sdk-install-modal-web/src/components/mm-install-modal/mm-install-modal.tsx b/packages/sdk-install-modal-web/src/components/mm-install-modal/mm-install-modal.tsx
@@ -94,11 +94,11 @@ export class InstallModal {
 
     return (
       <WidgetWrapper className="install-model">
-        <div class='backdrop' onClick={this.onClose}></div>
+        <div class='backdrop' onClick={() => this.onClose()}></div>
         <div class='modal'>
           <div class='closeButtonContainer'>
             <div class='right'>
-              <span class='closeButton' onClick={this.onClose}>
+              <span class='closeButton' onClick={() => this.onClose()}>
                 <CloseButton />
               </span>
             </div>
@@ -168,7 +168,7 @@ export class InstallModal {
 
               <button
                 class='button'
-                onClick={this.onStartDesktopOnboardingHandler}
+                onClick={() => this.onStartDesktopOnboardingHandler()}
               >
                 <InstallIcon />
                 <span class='installExtensionText'>

diff --git a/packages/sdk-install-modal-web/src/components/mm-select-modal/mm-select-modal.tsx b/packages/sdk-install-modal-web/src/components/mm-select-modal/mm-select-modal.tsx
@@ -157,7 +157,7 @@ export class SelectModal {
                 {t('SELECT_MODAL.CRYPTO_TAKE_CONTROL_TEXT')}
               </div>
 
-              <button class='button' onClick={this.connectWithExtensionHandler}>
+              <button class='button' onClick={() => this.connectWithExtensionHandler()}>
                 <ConnectIcon />
                 <span class='installExtensionText'>
                   {t('CONNECT_WITH_EXTENSION')}