-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build package as both CJS and ESM #203
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a361b76
Build source with SWC and types with TSC
Mrtenz 7bc76e5
Update package.json to reflect new dist folders
Mrtenz 2c01f9d
Build source and types in a separate CI job
Mrtenz 1eeb9ac
Update Yarn constraints
Mrtenz 4e7b138
yarn lint:fix
Mrtenz 44d0317
Add constraint for module field
Mrtenz 6c2f4fe
Synchronise `.swcrc.build.json` and `tsconfig.build.json` excludes
Mrtenz 4ca9446
Add constraints for exports field
Mrtenz bb4d34c
Add wildcard export
Mrtenz 84b858a
Remove test file
Mrtenz 982e68c
Remove exports field
Mrtenz 701dd76
Remove constraints for exports field
Mrtenz 455030a
Remove comment from SWC config
Mrtenz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just leaving a comment here for future reference. When we change the package to use SWC for other parts of the stack, such as testing, we need to keep in mind to use a different |
||
"$schema": "https://json.schemastore.org/swcrc", | ||
"jsc": { | ||
"parser": { | ||
"syntax": "typescript" | ||
}, | ||
"target": "es2020" | ||
}, | ||
"sourceMaps": true, | ||
"exclude": [ | ||
".*__fixtures__.*", | ||
Mrtenz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
".*__mocks__.*", | ||
".*__snapshots__.*", | ||
".*__tests?__.*", | ||
".*\\.test\\.?.*\\.tsx?", | ||
".*\\.d\\.tsx?" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need to run build on all these Node versions. But can be fixed in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but out of scope for this PR.