fix: Analytics issue where anonymousId and userId are not properly defined on first sent event

[NicolasMassart]

Description

This is a WIP to fix the issue.
The issue is fixed but the code is not the most clean I can provide (type casting to remove mostly)

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/2111

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.64%. Comparing base (1937f9a) to head (e4d9063).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
.../core/Analytics/MetaMetricsPrivacySegmentPlugin.ts	90.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13405      +/-   ##
==========================================
+ Coverage   61.58%   61.64%   +0.06%     
==========================================
  Files        1953     1952       -1     
  Lines       43442    43452      +10     
  Branches     5835     5840       +5     
==========================================
+ Hits        26753    26788      +35     
+ Misses      14905    14877      -28     
- Partials     1784     1787       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5191d17
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b48433aa-c71a-4f7e-882b-dad77b1ac5f1

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud