Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bridge feature routing skeleton #13404

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bfullam
Copy link
Contributor

@bfullam bfullam commented Feb 7, 2025

Description

Adds a routing skeleton for the mobile-native bridge feature and locks those routes behind feature flags.

Related issues

Fixes:

Manual testing steps

  1. Add export MM_BRIDGE_UI_ENABLED="true" to .js.env
  2. Go to wallet actions
  3. Click Bridge
  4. See Bridge scaffold

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bfullam bfullam requested review from a team as code owners February 7, 2025 13:08
Copy link
Contributor

github-actions bot commented Feb 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bfullam bfullam added team-swaps No E2E Smoke Needed If the PR does not need E2E smoke test run and removed team-identity labels Feb 7, 2025
@bfullam bfullam enabled auto-merge February 7, 2025 13:08
@bfullam bfullam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4aada83
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/514f77d1-bd75-4a61-b59e-ffd55e3d6ce2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@bfullam bfullam added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6593a1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b82618ce-2a93-467e-ac08-aad6492b284a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
68.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@bfullam bfullam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 72553e1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af9b87a8-c042-494e-b621-0ce93857a3da

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants