Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and deduplicate notification types and constants #13381

Merged

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Feb 6, 2025

Description

This removes the duplicate notification types that were copied before we started using the shared controllers.
NOTE - there still is some duplication through re-exporting some types, and we will tackle this separately.

Related issues

Fixes:

Manual testing steps

N/A - this is a type/import only change.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove duplicate code and utilise the shared types and constants.
This is a first pass, and I will probably do more decoupling and cleanup.
…f truth

to reduce additional file changes, we've re-exported the INotification type. Ideally I want to do another pass that removes this.
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner February 6, 2025 13:54
Copy link
Contributor

github-actions bot commented Feb 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya changed the title refactor: cleanup and deduplicate notification types and constants chore: cleanup and deduplicate notification types and constants Feb 6, 2025
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d497b31
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7fe51a5a-381d-495a-8e89-ebcf39dc0725

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b3461c1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/001614c2-f680-4a99-aac4-66363fcac646

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 78da3be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6aabefc-089c-47ff-a0ef-13456b5087c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Feb 6, 2025

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 2f0d885 Feb 7, 2025
43 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the refactor/cleanup-notification-types-and-constants branch February 7, 2025 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants