-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: simulation Fiat precision and Fiat flickers different value before decimals are applied #13371
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
precision is accessible by clicking on Unlimited
|
fix: related tests - mocking useSelector prevented chain Id from loading causing hideFiatForTestnet to be true
...s/Confirm/Info/TypedSignV3V4/Simulation/components/NativeValueDisplay/NativeValueDisplay.tsx
Outdated
Show resolved
Hide resolved
...s/Confirm/Info/TypedSignV3V4/Simulation/components/NativeValueDisplay/NativeValueDisplay.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to request changes because of this
#13371 (comment)
Apart from that LGTM
|
Description
TEST_NETWORK_IDS.includes(chainId) && !showFiatInTestnets;
was returning true in all cases as chainId was undefined.Related issues
Fixes: #13387
Manual testing steps
Screenshots/Recordings
Before
After example
**Real after with hidden value if "Unlimited" is shown w/ some token icons still loading **
**Before flickering issue **
CleanShot.2025-02-13.at.00.22.48.mp4
After
CleanShot.2025-02-13.at.00.30.17.mp4
Pre-merge author checklist
Pre-merge reviewer checklist