-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Redesign Permit support; fix: InfoRow padding and alignment #13369
base: main
Are you sure you want to change the base?
Conversation
- baseline causes each row to have different centering - valueComponent flex-end caused elements to align bottom of row - missing gap between label and row value
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
…efined -> toBeTruthy
"label": { | ||
"interacting_with": "Interacting with", | ||
"spender": "Spender" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the translation are label
only, this grouping may not be very useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay for organizational purposes
|
Description
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3919 (Permit support)
Fixes: #13368 (Permit Simulation value alignment)
Manual testing steps
https://develop.d3bkcslj57l47p.amplifyapp.com/ or https://metamask.github.io/test-dapp/
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist