Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Redesign Permit support; fix: InfoRow padding and alignment #13369

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Feb 5, 2025

Description

  • Add redesign Permit support
    • Displays appropriate title and subtitle
    • Displays "Spender" if applicable
  • Fix InfoRow padding and alignment
    • InfoRow alignItems: 'baseline' was causing inconsistent alignment since each wrapped row has its own relative baseline
  • Fix Permit Simulation values not aligning to the right
  • Updates DisplayURL test
    • replaces snapshot test
    • fix toBeDefined → toBeTruthy to ensure test checks null case

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3919 (Permit support)
Fixes: #13368 (Permit Simulation value alignment)

Manual testing steps

  1. Go to a test dapp
    https://develop.d3bkcslj57l47p.amplifyapp.com/ or https://metamask.github.io/test-dapp/
  2. Test various Permit signatures

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Feb 5, 2025
@digiwand digiwand requested review from a team as code owners February 5, 2025 22:47
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2121a96
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d53e89af-411c-46f8-99a7-8e0ca8518a40

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@digiwand digiwand requested a review from jpuri February 6, 2025 10:17
"label": {
"interacting_with": "Interacting with",
"spender": "Spender"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the translation are label only, this grouping may not be very useful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay for organizational purposes

Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Permit Simulation values are not right aligned
2 participants