feat: Implement redesigned staking confirmation entry point #13361
+656
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
added
No QA Needed
app/components/Views/confirmations/hooks/useConfirmationRedesignEnabled.ts
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/useConfirmationRedesignEnabled.ts
Outdated
Show resolved
Hide resolved
app/components/Views/confirmations/hooks/useTransactionMetadata.ts
Outdated
Show resolved
Hide resolved
jpuri
reviewed
Feb 5, 2025
app/components/Views/confirmations/components/Confirm/Info/Info.tsx
Outdated
Show resolved
Hide resolved
jpuri
reviewed
Feb 5, 2025
app/components/Views/confirmations/hooks/useConfirmationRedesignEnabled.test.ts
Outdated
Show resolved
Hide resolved
jpuri
reviewed
Feb 5, 2025
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fix the unwanted change made in #13361 ## **Related issues** Fixes e2e redesigned confirmation tests ## **Manual testing steps** N/A ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
OGPoyraz
added
Run Smoke E2E
7 tasks
OGPoyraz
added
Run Smoke E2E
amitabh94
previously approved these changes
Feb 7, 2025
OGPoyraz
requested review from
amitabh94,
jpuri,
pedronfigueiredo and
Matt561
pedronfigueiredo
approved these changes
Feb 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13361 +/- ##
==========================================
+ Coverage 61.58% 61.82% +0.24%
==========================================
Files 1953 1969 +16
Lines 43442 43796 +354
Branches 5835 5913 +78
==========================================
+ Hits 26753 27077 +324
- Misses 14905 14919 +14
- Partials 1784 1800 +16 ☔ View full report in Codecov by Sentry. |
|
jpuri
approved these changes
Feb 7, 2025
Matt561
approved these changes
Feb 7, 2025
|
@amitabh94 just removed you from reviewers because I got approval from Matthew, fyi |
sethkfman
approved these changes
Feb 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-7.41.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements entry point for staking deposit confirmation.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4078
Manual testing steps
N/A
Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-06.at.13.00.38.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist