chore: bump detox to 20.32.0 #13344

chrisleewilcox · 2025-02-04T19:44:43Z

Description

Bump detox to version 20.32.0.
This will also require bumping minSdk version.
According to cursor...

Related issues

Related: #13321

Manual testing steps

Should continue to be able to run e2e locally.
Should continue to be able to run e2e on bitrise.

Scenario: Android 6 devices upgrading to this version of the app
GIVEN I have Android 6 device
AND I have mobile app installed
WHEN I upgrade mobile app built with minSdkVersion 24
THEN upgrade is successful
AND mobile app is functioning as expected

Scenario: Install this version of the app on Android 6 device
GIVEN I have Android 6 device
WHEN I install this version of mobile app
THEN error indicating app is not supported on device

Screenshots/Recordings

Before

After

See link issue.

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-04T19:44:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-02-04T19:46:18Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected] 🔁 npm/[email protected]	environment	`0`	40.5 kB	asafkorem
npm/[email protected] 🔁 npm/[email protected]	environment, eval, filesystem, network, shell, unsafe	`+5`	15 MB	wix.mobile

View full report↗︎

socket-security · 2025-02-04T19:46:20Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Install scripts	npm/[email protected]	Install script: postinstall Source: `node scripts/postinstall.js`	`package.json` `yarn.lock`	⚠︎
Shell access	npm/[email protected]	Module: child_process Location: Package overview	`package.json` `yarn.lock`	🚫
Network access	npm/[email protected]	Module: net Location: Package overview	`package.json` `yarn.lock`	🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/[email protected]

chrisleewilcox · 2025-02-06T23:46:37Z

android/app/build.gradle

@@ -288,7 +288,7 @@ dependencies {
    } else {
        implementation jscFlavor
    }
-    androidTestImplementation('com.wix:detox-legacy:+') {
+    androidTestImplementation('com.wix:detox:+') {


This change was to address build issue with latest version of detox to use latest packages.

chrisleewilcox · 2025-02-06T23:47:24Z

android/build.gradle

@@ -4,7 +4,7 @@ buildscript {

 	ext {
 		buildToolsVersion = "34.0.0"
-		minSdkVersion = project.hasProperty('minSdkVersion') ? project.getProperty('minSdkVersion') : 23
+		minSdkVersion = project.hasProperty('minSdkVersion') ? project.getProperty('minSdkVersion') : 24


This change was to address build issue with latest version of detox to use minSdkVersion 24.

chrisleewilcox · 2025-02-06T23:47:42Z

package.json

@@ -459,7 +459,7 @@
    "browserstack-local": "^1.5.1",
    "chromedriver": "^123.0.1",
    "depcheck": "^1.4.7",
-    "detox": "^20.27.5",
+    "detox": "20.32.0",


Bump detox to this version.

chrisleewilcox · 2025-02-06T23:49:09Z

yarn.lock

+detox-copilot@^0.0.27:
+  version "0.0.27"
+  resolved "https://registry.yarnpkg.com/detox-copilot/-/detox-copilot-0.0.27.tgz#350ee91ae6ba77acac78513ccbda7aafcb3c6faf"
+  integrity sha512-H2febTNp0arVx2A8rvM1C2BwDiBEP/2Ya8Hd1mVyV66rR5u8om1gdIypaRGm+plpTLCHhlefe4+7qLtHgVzpng==

-detox@^20.27.5:
-  version "20.27.5"
-  resolved "https://registry.yarnpkg.com/detox/-/detox-20.27.5.tgz#f67d1a0c9ddbb2b6edb838e1b32c63b486be66ea"
-  integrity sha512-JBe3fONwaSxYubd/36SZh3c2MaYs+Cx7sOA4GJfh16QTyoB7XvvbGrSlQDTbag/f0j5RZt4judPtg5A3P1/Uhg==
+detox@20.32.0:
+  version "20.32.0"
+  resolved "https://registry.yarnpkg.com/detox/-/detox-20.32.0.tgz#d10f4ba91ed1c4b2c39eaf9db01935560b2e962a"
+  integrity sha512-xi2FSkoZ+8XYbfOFaMpC1uMKiuRlx0AXjnzTwuCGxjCsntM+YIU/zlACRjmsIAH4pHt7yVlJeV8xZyVGqIeeOg==
  dependencies:
    ajv "^8.6.3"
    bunyan "^1.8.12"
    bunyan-debug-stream "^3.1.0"
    caf "^15.0.1"
    chalk "^4.0.0"
    child-process-promise "^2.2.0"
-    detox-copilot "^0.0.23"
+    detox-copilot "^0.0.27"


yarn.lock changes after running yarn add [email protected]

github-actions · 2025-02-07T00:01:38Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: da9aef1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f5a0385-d8f6-40a1-9d49-657eef448077

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2025-02-07T01:03:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bump detox to 20.32.0

990cc7c

metamaskbot added the team-qa QA team label Feb 4, 2025

chrisleewilcox added 2 commits February 4, 2025 12:17

update detox ref package path

363462f

update minSdk buildscript

da9aef1

chrisleewilcox commented Feb 6, 2025

View reviewed changes

chrisleewilcox marked this pull request as ready for review February 6, 2025 23:50

chrisleewilcox requested review from a team as code owners February 6, 2025 23:50

chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 6, 2025

Merge branch 'main' into detox/version-bump-20.32.0

7d7c77f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump detox to 20.32.0 #13344

chore: bump detox to 20.32.0 #13344

chrisleewilcox commented Feb 4, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025

socket-security bot commented Feb 4, 2025 •

edited

Loading

socket-security bot commented Feb 4, 2025 •

edited

Loading

chrisleewilcox Feb 6, 2025

chrisleewilcox Feb 6, 2025 •

edited

Loading

chrisleewilcox Feb 6, 2025

chrisleewilcox Feb 6, 2025

github-actions bot commented Feb 7, 2025 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Feb 7, 2025

chore: bump detox to 20.32.0 #13344

Are you sure you want to change the base?

chore: bump detox to 20.32.0 #13344

Conversation

chrisleewilcox commented Feb 4, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 4, 2025

socket-security bot commented Feb 4, 2025 • edited Loading

socket-security bot commented Feb 4, 2025 • edited Loading

Next steps

chrisleewilcox Feb 6, 2025

Choose a reason for hiding this comment

chrisleewilcox Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

chrisleewilcox Feb 6, 2025

Choose a reason for hiding this comment

chrisleewilcox Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 7, 2025 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Feb 7, 2025

Quality Gate passed

chrisleewilcox commented Feb 4, 2025 •

edited

Loading

socket-security bot commented Feb 4, 2025 •

edited

Loading

socket-security bot commented Feb 4, 2025 •

edited

Loading

chrisleewilcox Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 7, 2025 •

edited by metamaskbot

Loading