Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename ControllerMessenger to Messenger #13302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Rename ControllerMessenger to Messenger #13302

wants to merge 1 commit into from
+23 −19

Conversation

cryptodev-2s
Copy link
Contributor

Explanation

Rename RestrictedControllerMessenger to RestrictedMessenger and ControllerMessenger to Messenger.

References

Relates to #4538

Changelog

No functional changes.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@cryptodev-2s cryptodev-2s self-assigned this Jan 31, 2025
@cryptodev-2s cryptodev-2s requested review from a team as code owners January 31, 2025 20:17
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 31, 2025
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d524210
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27d70044-d05a-4ba4-9902-471a9288810a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/use-renamed-messenger branch from d524210 to b355324 Compare February 3, 2025 11:02
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: b355324
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02fffe73-fe81-4e86-b31a-7c9edd829a78

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/use-renamed-messenger branch from b355324 to 115ef37 Compare February 3, 2025 11:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.18%. Comparing base (ef3b5d1) to head (115ef37).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13302   +/-   ##
=======================================
  Coverage   61.18%   61.18%           
=======================================
  Files        1937     1937           
  Lines       43131    43131           
  Branches     5862     5862           
=======================================
  Hits        26391    26391           
  Misses      14963    14963           
  Partials     1777     1777

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 115ef37
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/23b31eff-f0e8-4900-a9e0-70308cc37c43

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7c597d0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58ad6a25-4df8-4d43-8ad0-ad1bf1e8b6b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 3, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/use-renamed-messenger branch from d7fe936 to b361013 Compare February 4, 2025 12:23
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b361013
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/661fea2e-d314-4973-8e31-09b2ccc1facf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/use-renamed-messenger branch from b361013 to bcc265e Compare February 4, 2025 13:42
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bcc265e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6162f514-85b3-4e36-a673-b0e1711b63e3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/use-renamed-messenger branch from bcc265e to c91abae Compare February 5, 2025 12:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c91abae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5e9676a5-4a7d-4e2a-9037-2e9921899d77

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/use-renamed-messenger branch from c91abae to bc695e0 Compare February 6, 2025 10:22
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bc695e0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/77d99b1f-052d-43e9-aba9-28f830469cc9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cryptodev-2s cryptodev-2s

Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptodev-2s @codecov-commenter @metamaskbot