Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snaps dynamic UI #12429

Open
wants to merge 87 commits into
base: main
Choose a base branch
from
Open

feat: snaps dynamic UI #12429

wants to merge 87 commits into from

Conversation

Daniel-Cross
Copy link
Contributor

@Daniel-Cross Daniel-Cross commented Nov 26, 2024

Description

This PR integrates the Snaps Dynamic UI controller and components to allow different dialog prompts to show on the screen.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/738

Manual testing steps

  1. Make a Flask build
  2. Go to: https://metamask.github.io/snaps/test-snaps/latest/ in the in app browser
  3. Connect the Snaps Dialog snap
  4. Try to launch the different snaps prompts.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Daniel-Cross Daniel-Cross self-assigned this Dec 16, 2024
@Daniel-Cross Daniel-Cross added team-accounts team-snaps-platform Snaps Platform team Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 16, 2024
@Daniel-Cross Daniel-Cross changed the title feature: snaps dynamic UI feat: snaps dynamic UI Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 04876a5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d474e6c3-86f1-4359-84e2-7c0517478204

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

6 participants