Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Currently keystone lib will throw
KeystoneError#Tx_canceled
wh…
…ich will crash the mobile app (#13313) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR will fix #13259 issue. When user reject signature in QR screen, the `@keystonehq/metamask-airgapped-keyring` will throw `KeystoneError#Tx_canceled` error. however, for some reason, Hermes engine threat that error as object and go to Crash flow. I have fixed it by adding above uncatch error into our global ErrorHandler.ts to specially thread it. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** ``` Scenario: Swap with QR account and Reject QR modal GIVEN I have QR account selected WHEN I swap AND Reject QR modal THEN modal is closed (FAILED: app closes and crash alert is displayed) AND app is still functioning (FAILED) ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/6313a2fa-e385-4a58-b7ac-32d5d9d422cf ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information