-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snaps): Add background color prop to Snaps UI Container component #29095
Draft
david0xd
wants to merge
3
commits into
main
Choose a base branch
from
dd/add-snap-ui-container-bg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
david0xd
force-pushed
the
dd/add-snap-ui-container-bg
branch
from
January 10, 2025 10:37
f83bcff
to
0f5f5d3
Compare
Builds ready [0f5f5d3]
Page Load Metrics (1675 ± 43 ms)
Bundle size diffs
|
Builds ready [fdf9081]
Page Load Metrics (1629 ± 43 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [406ca2d]
Page Load Metrics (1811 ± 85 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
backgroundColor
property to Container component.Background colors that can be used are predefined as: default and alternative.
This PR deliberately disables the
backgroundColor
feature for containers used within Transaction Insights pages (Snaps).Related issues
Fixes: MetaMask/snaps#2906
Related Snaps PR: MetaMask/snaps#2950
Manual testing steps
Container
in its content withbackgroundColor
defined (e.g.<Container backgroundColor="default">
).Some source code used for testing:
Source code used for Transaction Insight content:
Screenshots/Recordings
Before
Note: Changing container colors was not possible before.
After
Here are some examples when colors are changed (specified as a prop on container).
Pre-merge author checklist
Pre-merge reviewer checklist