-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch authentication controller sign out validation #28847
Closed
Prithpal-Sooriya
wants to merge
3
commits into
main
from
hotfix/patch-authentication-signout-validation
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
ae485b3
fix: patch authentication controller sign out validation
Prithpal-Sooriya da1ccd4
Merge branch 'main' of github.com:MetaMask/metamask-extension into ho…
Prithpal-Sooriya eddb2b1
Merge branch 'main' into hotfix/patch-authentication-signout-validation
Prithpal-Sooriya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
.yarn/patches/@metamask-profile-sync-controller-npm-2.0.0-02e028ab48.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| diff --git a/dist/controllers/authentication/AuthenticationController.cjs b/dist/controllers/authentication/AuthenticationController.cjs | ||
| index cc9a5e8cf810a7369414e88b035894286499b3fe..5c6bcb39164cc625cc834be1dd3cae5936ef682c 100644 | ||
| --- a/dist/controllers/authentication/AuthenticationController.cjs | ||
| +++ b/dist/controllers/authentication/AuthenticationController.cjs | ||
| @@ -72,7 +72,6 @@ class AuthenticationController extends base_controller_1.BaseController { | ||
| return accessToken; | ||
| } | ||
| performSignOut() { | ||
| - __classPrivateFieldGet(this, _AuthenticationController_instances, "m", _AuthenticationController_assertLoggedIn).call(this); | ||
| this.update((state) => { | ||
| state.isSignedIn = false; | ||
| state.sessionData = undefined; | ||
| diff --git a/dist/controllers/authentication/AuthenticationController.mjs b/dist/controllers/authentication/AuthenticationController.mjs | ||
| index 16fd8750844d2f8cc5b54676e5c94a42185cf287..803c60c5895d99cdf2da737011759882ffc47384 100644 | ||
| --- a/dist/controllers/authentication/AuthenticationController.mjs | ||
| +++ b/dist/controllers/authentication/AuthenticationController.mjs | ||
| @@ -69,7 +69,6 @@ class AuthenticationController extends BaseController { | ||
| return accessToken; | ||
| } | ||
| performSignOut() { | ||
| - __classPrivateFieldGet(this, _AuthenticationController_instances, "m", _AuthenticationController_assertLoggedIn).call(this); | ||
| this.update((state) => { | ||
| state.isSignedIn = false; | ||
| state.sessionData = undefined; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patched until profile-sync-controller changes are released.
The next upgrade of this package has an interdependency with the network controller.