Jl/caip multichain/cleanup middleware destroy #28751

jiexi · 2024-11-27T00:34:40Z

Description

Related issues

Core: MetaMask/core#4984

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…n/cleanup-middleware-destroy

jiexi · 2024-11-27T00:34:48Z

@metamaskbot update-policies

github-actions · 2024-11-27T00:34:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-11-27T00:35:41Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask-previews/[email protected]	Transitive: filesystem	`+8`	1.01 MB	mcmire, metamaskbot

🚮 Removed packages: npm/@json-schema-tools/[email protected], npm/@metamask-previews/[email protected]

View full report↗︎

metamaskbot · 2024-11-27T00:46:40Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2024-11-27T01:21:37Z

Builds ready [81867db]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1783 ± 67 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1572	2036	1781	136	65
		domContentLoaded	1508	1961	1737	129	62
		load	1575	2056	1783	139	67
		domInteractive	24	180	65	55	26
		backgroundConnect	11	101	52	27	13
		firstReactRender	16	75	36	20	10
		getState	4	52	16	12	6
		initialActions	0	1	0	0	0
		loadScripts	1057	1464	1275	106	51
		setupStore	6	59	14	14	7
		uiStartup	1759	2352	1980	154	74

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 30.81 KiB (0.53%)
ui: 626 Bytes (0.01%)
common: 466.93 KiB (5.74%)

…n/cleanup-middleware-destroy

metamaskbot · 2024-11-27T17:16:24Z

Builds ready [0f0bb96]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1709 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1569	2075	1717	125	60
		domContentLoaded	1522	2065	1680	134	64
		load	1531	2077	1709	132	63
		domInteractive	20	77	45	16	8
		backgroundConnect	14	72	40	21	10
		firstReactRender	16	79	42	24	11
		getState	5	81	20	21	10
		initialActions	0	1	0	0	0
		loadScripts	1096	1526	1237	108	52
		setupStore	6	11	8	1	1
		uiStartup	1706	2323	1884	147	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 30.81 KiB (0.53%)
ui: 626 Bytes (0.01%)
common: 466.93 KiB (5.74%)

…n/cleanup-middleware-destroy

metamaskbot · 2024-12-02T19:07:25Z

Builds ready [3005665]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1659 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	250	2180	1579	351	169
		domContentLoaded	1435	2102	1643	170	82
		load	1443	2184	1659	182	87
		domInteractive	22	56	30	9	4
		backgroundConnect	8	83	19	20	10
		firstReactRender	14	93	36	27	13
		getState	20	107	43	25	12
		initialActions	0	1	0	0	0
		loadScripts	1047	1682	1233	152	73
		setupStore	5	89	18	23	11
		uiStartup	1618	2535	1917	251	120

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 30.8 KiB (0.57%)
ui: 626 Bytes (0.01%)
common: 466.84 KiB (5.68%)

…try (#4984) ## Explanation Ensures that the subscription entry for a subscription is removed when the middleware is destroyed ## References Related: MetaMask/metamask-extension#28751 ## Changelog  ### `@metamask/package-a` - **<CATEGORY>**: Your change here - **<CATEGORY>**: Your change here ### `@metamask/package-b` - **<CATEGORY>**: Your change here - **<CATEGORY>**: Your change here ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

jiexi added 3 commits November 26, 2024 16:27

use preview build 7f262294 (sub middleware destroy cleanup)

8587442

Merge branch 'jl/caip-multichain-migrate-core' into jl/caip-multichai…

7d32306

…n/cleanup-middleware-destroy

lavamoat

2c395c3

metamaskbot added the team-wallet-api-platform label Nov 27, 2024

Update LavaMoat policies

81867db

Merge branch 'jl/caip-multichain-migrate-core' into jl/caip-multichai…

0f0bb96

…n/cleanup-middleware-destroy

jiexi added 6 commits December 2, 2024 09:18

Merge branch 'jl/caip-multichain-migrate-core' into jl/caip-multichai…

f901781

…n/cleanup-middleware-destroy

Merge branch 'jl/caip-multichain-migrate-core' into jl/caip-multichai…

2de1268

…n/cleanup-middleware-destroy

use preview build 1c8fd633 (separate middleware instance)

8d2b2dd

Merge branch 'jl/caip-multichain-migrate-core' into jl/caip-multichai…

2adafd0

…n/cleanup-middleware-destroy

use preview build b8323ae4 (separate middleware instance rebuilt)

3154dd8

use preview build 31564566 (separate middleware instance fixed)

c2bdfea

jiexi mentioned this pull request Dec 2, 2024

Override subscriptionManager.middleware.destroy to also remove sub entry MetaMask/core#4984

Merged

4 tasks

yarn dedupe

3005665

use preview build 57e6ab5d (separate middleware instance merged)

3dbd915

jiexi marked this pull request as ready for review December 2, 2024 20:30

jiexi requested a review from a team as a code owner December 2, 2024 20:30

jiexi merged commit 21b2181 into jl/caip-multichain-migrate-core Dec 2, 2024
7 of 11 checks passed

jiexi deleted the jl/caip-multichain/cleanup-middleware-destroy branch December 2, 2024 20:30

github-actions bot locked and limited conversation to collaborators Dec 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jl/caip multichain/cleanup middleware destroy #28751

Jl/caip multichain/cleanup middleware destroy #28751

jiexi commented Nov 27, 2024 •

edited

Loading

jiexi commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

socket-security bot commented Nov 27, 2024 •

edited

Loading

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Dec 2, 2024

Jl/caip multichain/cleanup middleware destroy #28751

Jl/caip multichain/cleanup middleware destroy #28751

Conversation

jiexi commented Nov 27, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

jiexi commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

socket-security bot commented Nov 27, 2024 • edited Loading

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Dec 2, 2024

jiexi commented Nov 27, 2024 •

edited

Loading

socket-security bot commented Nov 27, 2024 •

edited

Loading