Fix NetworkController Redux selectors #5193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
fix-network-selectors
branch
3 times, most recently
from
973e88a to
eb7baeb
Compare
When running tests, we are seeing the following warning: > An input selector returned a different result when passed same > arguments. This means your output selector will likely run more > frequently than intended. This is happening because the "input selector" in `selectAvailableNetworkClientIds` returns a new object reference (returned by `getNetworkConfigurations`) each time it is called. This violates the Redux guidelines outlined here: <https://redux.js.org/usage/deriving-data-selectors#optimizing-selectors-with-memoization>. To fix this, we split off the "input selector" into its own selector function which we then memoize.
mcmire
force-pushed
the
fix-network-selectors
branch
from
eb7baeb to
816d47b
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When running tests, we are seeing the following warning:
This is happening because the "input selector" in
selectAvailableNetworkClientIdsreturns a new object reference (returned bygetNetworkConfigurations) each time it is called. This violates the Redux guidelines outlined here: https://redux.js.org/usage/deriving-data-selectors#optimizing-selectors-with-memoization.To fix this, we split off the "input selector" into its own selector function which we then memoize.
References
Changelog
(Updated in PR.)
Checklist