Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused OpenSea key #5088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Remove unused OpenSea key #5088

wants to merge 1 commit into from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 20, 2024

Explanation

Remove unused OpenSea API key. This is a breaking change because of the API/type change, but it's not a functional change since it was already unused.

References

N/A

Changelog

See diff

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
    • I skipped this step in this case because the changes are trivial, despite being breaking.

@Gudahtt Gudahtt force-pushed the remove-unused-opensea-key branch 2 times, most recently from 208bc46 to ff82d24 Compare December 20, 2024 04:54
@Gudahtt
chore: Remove unused OpenSea key
0cbe7e9 
Remove unused OpenSea API key. This is a breaking change because of the
API/type change, but it's not a functional change since it was already
unused.
@Gudahtt Gudahtt force-pushed the remove-unused-opensea-key branch from ff82d24 to 0cbe7e9 Compare December 20, 2024 05:13
@Gudahtt Gudahtt marked this pull request as ready for review December 20, 2024 05:35
@Gudahtt Gudahtt requested review from a team as code owners December 20, 2024 05:35
cryptodev-2s
cryptodev-2s approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cryptodev-2s
cryptodev-2s approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@salimtb salimtb salimtb approved these changes

@bergeron bergeron bergeron approved these changes

Assignees
No one assigned
Labels
team-assets team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gudahtt @bergeron @salimtb @cryptodev-2s