fix: ensure signing out does not error

[Prithpal-Sooriya]

Explanation

We do not need to perform state assertions when signing out. This is to ensure if users get into weird situations, they can still sign out without error.

References

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3709

Changelog

@metamask/profile-sync-controller

• CHANGED removed assert logic in performSignOut() method

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[mirceanis]

Looks good

[mathieuartu]

LGTM!