Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation options from OOPS Applications #126

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ss421
Copy link
Contributor

@ss421 ss421 commented Dec 5, 2024

Description

Update required by https://github.com/JCSDA-internal/oops/pull/2795, see also: JCSDA-internal/oops#2794.

Dependencies

build-group=JCSDA-internal/oops#2795
build-group=JCSDA-internal/saber#979
build-group=JCSDA-internal/ioda#1391
build-group=JCSDA-internal/ufo#3548

Testing

Run test suite via: ./bin/bbb play "no_app_val" -z TASKS=all_ctest All test have passed, see: no_app_val

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@ss421 ss421 self-assigned this Dec 5, 2024
@ss421 ss421 requested a review from twsearle as a code owner December 5, 2024 09:47
Copy link
Collaborator

@twsearle twsearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve, looks good to me. Hopefully we can get these schema generated again in the future some other way!

@ss421 ss421 requested a review from mikecooke77 December 5, 2024 10:02
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All ran OK.

@ytremolet
Copy link

The OOPS PR is merged.

@twsearle twsearle merged commit dee5fb9 into develop Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants