Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model variable naming sprint: part 2 #230

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

ss421
Copy link
Contributor

@ss421 ss421 commented Oct 10, 2024

Description

As part of variable name code sprint, this PR renames variables from group 2:

specific_humidity -> water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water
specific_humidity_at_two_meters_above_surface -> water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water_at_2m

Dependencies

build-group=https://github.com/JCSDA-internal/vader/pull/278
build-group=https://github.com/JCSDA-internal/saber/pull/956
build-group=https://github.com/JCSDA-internal/ufo/pull/3489
build-group=JCSDA-internal/ufo-data#455
build-group=https://github.com/JCSDA-internal/ops-um-jedi/pull/238
build-group=https://github.com/JCSDA-internal/lfric-jedi/pull/915
build-group=https://github.com/MetOffice/jjtests/pull/53
build-group=https://github.com/JCSDA-internal/oops/pull/2767

Impact

No impacts expected beyond the list in dependencies above

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@ss421 ss421 self-assigned this Oct 10, 2024
@ss421
Copy link
Contributor Author

ss421 commented Oct 10, 2024

Note: tested via the bundle and some test fail due to missing UFO branch. I don't expect any impact from that just working tests... Please review on the understanding that the test will pass. Thankyou.

@mikecooke77 mikecooke77 marked this pull request as ready for review October 10, 2024 22:21
Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@mikecooke77
Copy link
Collaborator

mikecooke77 commented Oct 11, 2024

Given the change from water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water to water_vapor_mixing_ratio_wrt_moist_air, I have created a new branch:

feature/variable_names_part2_mcc

I didn't want to just replace the branch. @ss421 I'll leave you to do that if you are happy.

All tests passing (except known ufo aircraft varbc with debug):
http://fcm1/cylc-review/cycles/mcooke?&suite=mobundle-batch2

Note: As well as mo repos there is also an update to vader.

@mikecooke77 mikecooke77 merged commit fb7f33a into develop Oct 16, 2024
5 checks passed
@mikecooke77 mikecooke77 deleted the feature/variable_names_part2 branch October 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants