-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model variable naming sprint: part 2 #230
Conversation
Note: tested via the bundle and some test fail due to missing UFO branch. I don't expect any impact from that just working tests... Please review on the understanding that the test will pass. Thankyou. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in my environment. Works as expected.
Given the change from feature/variable_names_part2_mcc I didn't want to just replace the branch. @ss421 I'll leave you to do that if you are happy. All tests passing (except known ufo aircraft varbc with debug): Note: As well as mo repos there is also an update to vader. |
Description
As part of variable name code sprint, this PR renames variables from group 2:
specific_humidity
->water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water
specific_humidity_at_two_meters_above_surface
->water_vapor_mixing_ratio_wrt_moist_air_and_condensed_water_at_2m
Dependencies
build-group=https://github.com/JCSDA-internal/vader/pull/278
build-group=https://github.com/JCSDA-internal/saber/pull/956
build-group=https://github.com/JCSDA-internal/ufo/pull/3489
build-group=JCSDA-internal/ufo-data#455
build-group=https://github.com/JCSDA-internal/ops-um-jedi/pull/238
build-group=https://github.com/JCSDA-internal/lfric-jedi/pull/915
build-group=https://github.com/MetOffice/jjtests/pull/53
build-group=https://github.com/JCSDA-internal/oops/pull/2767
Impact
No impacts expected beyond the list in dependencies above
Checklist