Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Met Office varname (sprint_0) #224

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

ss421
Copy link
Contributor

@ss421 ss421 commented Oct 3, 2024

Description

Update the following variable names:

m_v -> water_vapor_mixing_ratio_wrt_dry_air
m_ci -> cloud_ice_mixing_ratio_wrt_dry_air
m_cl -> cloud_liquid_water_mixing_ratio_wrt_dry_air
m_r -> rain_mixing_ratio_wrt_dry_air
m_t -> total_water_mixing_ratio_wrt_dry_air
relative_humidity_2m -> relative_humidity_at_2m

More details are included in lfric-jedi issue: 899

Issue(s) addressed

Resolves #899

Testing

Tested via mo-bundle, sith and malak. Output for all the tests will be collated in https://github.com/JCSDA-internal/lfric-jedi/issues/899

Dependencies

Impact

Effects the Met Office model interfaces and workflows only.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@ss421 ss421 marked this pull request as ready for review October 3, 2024 11:49
@yaswant
Copy link
Collaborator

yaswant commented Oct 3, 2024

@matthewrmshin Note the GitHub Action workflows were skipped for this PR. I am not sure why.

@ss421
Copy link
Contributor Author

ss421 commented Oct 3, 2024

@matthewrmshin Note the GitHub Action workflows were skipped for this PR. I am not sure why.

Is it because I dont have ready to merge label?:

This PR does not have 'ready to merge' label.

I wasn't sure if I should add it yet as this is a coordinated merge.

@yaswant
Copy link
Collaborator

yaswant commented Oct 3, 2024

Ready to Merge is a separate workflow and has correctly failed. But the main CI build-test has not started at all. Did you have this PR marked as Draft by any chance? Also you could actually use the build-group=... syntax in your PR instead of the dependency list?

Copy link
Collaborator

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my environment. Works as expected.

@matthewrmshin matthewrmshin merged commit 99c4776 into develop Oct 3, 2024
7 of 8 checks passed
@matthewrmshin matthewrmshin deleted the feature/varname_mo_sprint_0 branch October 3, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants