separate model variables and obs variables types

[twsearle]

Description

Use the new oops::ObsVariables for observations and oops::Variables for model variables.

Issue(s) addressed

Resolves #69

Impact

Resolves compile-time errors due to recent oops changes.

Checklist

• I have updated the unit tests to cover the change
• I have linted my code using cpplint
• I have run the unit tests
• I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

[twsearle]

I am seeing a lot of mo-bundle issues that don't seem to be related to my change, but might be related to me commenting out all lfric etc libraries:
http://fcm1/cylc-review/view/tsearle?&suite=mobb-oops2591&no_fuzzy_time=0&path=log/job/1/cmake_mo__cray_gnu_debug/01/job.err

changes look straight-forward to me otherwise and unit tests pass. If I get a green light I will push ahead as we really want to fix this up as quickly as possible to be able to run all the comparison tests etc.

[mo-joshuacolclough]

Thanks looks OK to me, although not an expert on this repo, and as mentioned on orca-jedi I haven't run the tests.

[twsearle]

Thanks looks OK to me, although not an expert on this repo, and as mentioned on orca-jedi I haven't run the tests.

The tests are run as part of the CI, so no need if there is a green tick :) Its more the full integration and build on XC and spice that concerned me, but I think that is probably just me commenting out too many repos. As you say, it can't really get worse and I can always open another if there are still issues.