Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iris-grib library support #960

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Add iris-grib library support #960

merged 3 commits into from
Dec 6, 2024

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Dec 5, 2024

A lot of AI data is written in grib, which is a WMO standard format. We need the iris-grib library to support loading these files.

Fixes #959

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 self-assigned this Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Coverage

jfrost-mo and others added 2 commits December 5, 2024 13:00
The failures we are getting in CI might be due to memory issues, as we
are running 8 conda-locks in parallel. This should reduce that, though
it will be slower.
@jfrost-mo
Copy link
Member

I've now gotten this PR working. I had to serialize the conda lock file generation, as before it was running out of memory on the CI machine where it was running all the conda-locks in parallel.

It should now be ready to go.

@jfrost-mo
Copy link
Member

@jwarner8 if you're happy for me to review and merge this, just press "Ready for review".

@jfrost-mo jfrost-mo self-requested a review December 5, 2024 15:55
Copy link
Contributor Author

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jwarner8 jwarner8 marked this pull request as ready for review December 6, 2024 09:25
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jwarner8 jwarner8 merged commit b365232 into main Dec 6, 2024
8 checks passed
@jwarner8 jwarner8 deleted the add_iris_grib branch December 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRIB support
2 participants