Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with rose-suite.conf variable #1082

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix issue with rose-suite.conf variable #1082

merged 1 commit into from
Jan 27, 2025

Conversation

jwarner8
Copy link
Contributor

Rose edit will not open as a variable is not set.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 added bug Something isn't working small Small issue that should be quick to resolve labels Jan 27, 2025
@jwarner8 jwarner8 self-assigned this Jan 27, 2025
@jwarner8 jwarner8 requested a review from jfrost-mo January 27, 2025 14:32
@jwarner8 jwarner8 changed the title Fix issue with conf Fix issue with rose-suite.conf variable Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

Coverage

jfrost-mo
jfrost-mo approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfrost-mo jfrost-mo merged commit b2c1bf0 into main Jan 27, 2025
8 checks passed
@jfrost-mo jfrost-mo deleted the fix_conf branch January 27, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees

@jwarner8 jwarner8

Labels
bug Something isn't working small Small issue that should be quick to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwarner8 @jfrost-mo