Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary computation from age-of-air test #1081

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Jan 27, 2025

We already have the test data leaded, so we should use it rather than recalculate it.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo self-assigned this Jan 27, 2025
@jfrost-mo jfrost-mo added the cleanup Non-functional improvement label Jan 27, 2025
@jfrost-mo jfrost-mo marked this pull request as ready for review January 27, 2025 13:43
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Coverage

We already have the test data leaded, so we should use it.
Copy link
Contributor

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, a lot of unnecessary loading.

@jfrost-mo jfrost-mo merged commit 2432e98 into main Jan 27, 2025
8 checks passed
@jfrost-mo jfrost-mo deleted the aoa_test_speedup branch January 27, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants