Use CSET read operator to load test data, and improve various fragile tests #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
force-pushed
the
use_cset_read_operator_in_tests
branch
3 times, most recently
from
55f7370 to
726e37d
Compare
daflack
reviewed
Jan 28, 2025
daflack
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
As now loaded by CSET the time coordinate should not appear on its own, as all cubes given a realization coordinate. Therefore, this part of the operator that is "not tested" can be removed when the convection code is updated to run with LFRic. Please create an issue.
They were very brittle due to relying on the serialisation of a method signature. These have been converted to directly check the concerned properties of the cubes.
Also use more robust checking on single point regrid tests and use range rather than long list of expected points.
jfrost-mo
force-pushed
the
use_cset_read_operator_in_tests
branch
from
a2055ff to
993c6f6
Compare
|
I've rebased to fix some merge conflicts, and improve the data loading in the convection tests in commit 993c6f6, which is the only new once since your last review. I'd appreciate another review of those additional changes before I merge this. |
daflack
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly wide ranging set of test improvements. The main focus is ensuring we are using the CSET read operators to load data, so it is representative of what CSET will actually be handling. The only place that remains using
iris.loadis the tests for the read operators themselves.There are also several robustness improvements to tests, to check the desired property directly rather than some tangential thing, such as the
repr().Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.