Spatial difference plots #1061
Merged
Spatial difference plots #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Jan 21, 2025
jfrost-mo
force-pushed
the
improve_rose_edit
branch
from
1bff1c9 to
e22ae85
Compare
jfrost-mo
force-pushed
the
difference_plots
branch
from
c57308b to
2d79a5b
Compare
This uses the `cset_comparison_base` cube attribute to determine which cube to use as the comparison base. For now it can only take difference between the same validity times, and it filters down to only the common times.
The bwr colour map is chosen to highlight differences.
This required adding some LFRic test data. This is a small cutout over Exeter from an LFRic_apps vn1.1 run valid for 20220101T0000Z.
jfrost-mo
force-pushed
the
difference_plots
branch
from
62597a7 to
169b92f
Compare
jfrost-mo
requested review from
daflack and
jwarner8
and removed request for
daflack
jfrost-mo
commented
Jan 24, 2025
jfrost-mo
commented
Jan 24, 2025
daflack
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Science review:
From a science perspective the documentation is clear. However, the recipe is less so - see comment. There do not appear to be any issues from a science implementation perspective. Code not ran as part of the science review and should be part of the technical review.
Approved from Science perspective.
We instead just use the order of the latitude coordinate, which is what we care about anyway.
We no longer need it, and ideally want code to be model agnostic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At long last this is ready to go into CSET. This PR adds a new
misc.differenceoperator, a recipe and an include file exercising it.The linking into the rose-edit was actually done in #1055, so that toggle will actually do something now.
Fixes #455
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.