Difference plots and other stuff #1025
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo:
|
jfrost-mo
force-pushed
the
difference_plots_and_other_stuff
branch
from
e1b8444 to
ace063a
Compare
Not all spatial plots are contour plots nowdays.
Non-matching attributes are removed.
Still WIP, as doesn't yet support UM.
It isn't in any hot paths, and makes inspecting it much nicer.
It now removes coordinates that are not present on all cubes.
Currently can't do UM-LFRic plots correctly, as the arrays are flipped.
This allows having a unique colour bar range for each difference type.
We only need it for the array flipping, so it would be best to not make it unnecessarily accessible.
This reflects the non-sequential nature of the variable, and how it will soon contain multiple values.
This syntax has been avaliable since python 3.9, which is beyond our minimum supported version of python 3.10, therefore it can all be removed.
As they may contain glob patterns, Paths don't really work.
This is more compatible for saving into a file than boolean.
This also makes paths and file loading more consistently handled.
jfrost-mo
force-pushed
the
difference_plots_and_other_stuff
branch
from
ace063a to
5ecb159
Compare
|
|
The lead time functionality is a subset, so we only need the one mode.
This change switches to a generated rose-meta.conf, so it is much easier to maintain. It also removes a number of obsolete keys, updates descriptions, makes analysis_offset and analysis_period per-model, and removes the s/crimes against rose edit/mapping between model and fieldname/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be broken into multiple, then closed.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.