Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upload-artifact and download-artifact action to v4 #652

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

ValentinBuira
Copy link
Contributor

Bump upload-artifact and download-artifact action to v4.

Some changes were required in the PR because in the V4, artifact are immutable once created. You can't incrementally add file to an artifact anymore, we have to use the actions/upload-artifact/merge@v4 see https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#merging-multiple-artifacts

Copy link
Contributor

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the output between v3 and v4 and it looks the same 👌🏻 Thanks for adjusting this @ValentinBuira

@tomasMizera tomasMizera merged commit 7d4d0ae into master Jan 16, 2025
7 checks passed
@tomasMizera tomasMizera deleted the upgrade-actions branch January 16, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants