Project history : Add a version viewer windows in the plugin #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject-history-refactor
|
Hi @uclaros we have a big one here :) Thanks! |
tomasMizera
added
the
requires dependency release
uclaros
reviewed
Dec 9, 2024
Comment on lines
+418
to
+421
| def on_scrollbar_changed(self, value): | ||
|
|
||
| if self.ui.history_treeview.verticalScrollBar().maximum() <= value: | ||
| self.fetch_from_server() |
There was a problem hiding this comment.
If the first page of data fits in the tree view and does not need a scrollbar, then the second page will not be fetched
There was a problem hiding this comment.
Yes but it's very unlikely to happen as we fetch 100 versions at once.
If @tomasMizera agree we can leave it as is
| # Only fetching when previous is finshed | ||
| return | ||
| else: | ||
| self.fetcher.start() |
There was a problem hiding this comment.
Is there any visual indication that we are fetching?
There was a problem hiding this comment.
Not at the moment, I think the cleanest way to do so would be to add a temporary items at the end of the version table Saying "Fetching more versions ⏳"
* Cleanup duplicate * Style
* auto restore window geometry * handle disconnection from internet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor and enhancement to bring a new history window to browse the history of a project directly from the plugin
To open the new windows a new toolbar button has been added.
The windows is divided in three parts for the users to be able to:
This PR is marked as draft because some testing are still required and the feature still have rough edges
For reviewer a brief technical documentation is available in the comment