Hiding tracking layer while recording #3700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12604420959Details
💛 - Coveralls |
VitorVieiraZ
changed the title
tomasMizera
requested changes
Jan 6, 2025
| if ( !layer ) | ||
| return false; | ||
|
|
||
| QgsProject *project = QgsProject::instance(); |
There was a problem hiding this comment.
Everything looks good, the only bit is that we should not read the QGIS project instance as singleton. Let's pass it in as parameter instead (via QML?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new filter condition to the recording layer model to ensure a layer is added only if it is not the position tracking layer.
Resolves #3687