Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix uneccessary confirmation dialog when reopenning a form #3690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ValentinBuira
Copy link
Contributor

Previously we kept the left most form component in the stackview for performance but it prevent the call to recalculateDerivedItems and the appropriate HasAnyChanges signal

This PR solve the issue by destroying the last form component and rebuild it each time a form is open

May partially solves #3671

Copy link

github-actions bot commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12138645669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 178 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.05%) to 60.408%

Files with Coverage Reduction New Missed Lines %
input/core/merginapi.h 1 97.56%
input/core/merginprojectmetadata.cpp 4 89.25%
input/app/mmstyle.h 49 1.95%
input/core/merginapi.cpp 124 78.72%
Totals Coverage Status
Change from base Build 12135499446: 0.05%
Covered Lines: 7876
Relevant Lines: 13038

💛 - Coveralls

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this fix in place, we should be safe to revert the fix introduced in #2880, @alexd0793 When you test this, please test also this issue: #2879

@ValentinBuira let's also bear in mind that activeFormIndex will now often (when no form is opened) be -1 (previously 0). I checked the code and even though it works a bit differently now, I do not see any issue with it.

if ( formsStack.depth > 1 ) {
formsStack.pop()
}
else{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
else{
else {

@tomasMizera tomasMizera changed the title Fix uneccessary confirmation dialog when reopenning a form [WIP] Fix uneccessary confirmation dialog when reopenning a form Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants